Skip to content

docs(async_client): Fix typo in get_mtls_endpoint_and_cert_source doc #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 3 commits into from
Dec 8, 2022
Merged

docs(async_client): Fix typo in get_mtls_endpoint_and_cert_source doc #662

Mariatta merged 3 commits into from
Dec 8, 2022

Conversation

@rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Nov 17, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea Just a typo fix, not needed IMO
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) This is a docs fix

@rwhogg rwhogg requested review from a team as code owners November 17, 2022 14:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Nov 17, 2022
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@parthea parthea closed this Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@parthea parthea reopened this Dec 7, 2022
@Mariatta Mariatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@Mariatta Mariatta added owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2022
@Mariatta Mariatta merged commit b431b4a into googleapis:main Dec 8, 2022
@release-please release-please bot mentioned this pull request Dec 8, 2022
Merged
@rwhogg rwhogg deleted the fix-typo branch December 8, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mariatta Mariatta Mariatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rwhogg @Mariatta @parthea @yoshi-kokoro