feat: query profiling part 2: asynchronous #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchin
commented
Sep 11, 2024
| async for response in response_iterator: | ||
| result = _query_response_to_result(response) | ||
| yield result | ||
| if result: |
Contributor
Author
There was a problem hiding this comment.
Note: I added this so it doesn't yield an empty list when we have explain_options=ExplainOptions(analyze=False). In this case no results are returned but we get a message containing explain metrics info.
daniel-sanche
requested changes
Sep 13, 2024
Contributor
daniel-sanche
left a comment
There was a problem hiding this comment.
mostly looks good, but a few small comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a branch of the synchronized PR (#938). Will rebase once #938 is merged.