Skip to content

Conversation

@lahuang4
Copy link
Contributor

No description provided.

…ubscriptions to encourage more performant subscribe
@lahuang4 lahuang4 requested review from a team as code owners January 10, 2025 00:55
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 10, 2025
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jan 10, 2025
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) January 10, 2025 01:05
@hongalex
Copy link
Member

@lahuang4
Copy link
Contributor Author

It looks like the Kokoro build failed, but it was a different test case which failed:

=================================== FAILURES ===================================
__________________ test_opentelemetry_flow_control_exception ___________________

...

        spans = span_exporter.get_finished_spans()
        # Span 1 = Publisher Flow Control Span of first publish
        # Span 2 = Publisher Batching Span of first publish
        # Span 3 = Publisher Flow Control Span of second publish(raises FlowControlLimitError)
        # Span 4 = Publish Create Span of second publish(raises FlowControlLimitError)
>       assert len(spans) == 4
E       assert 5 == 4
E        +  where 5 = len((, , ))

tests/unit/pubsub_v1/publisher/test_publisher_client.py:301: AssertionError

@hongalex could you help me re-run the Kokoro check? Not sure how to trigger it myself.

(Looks like there is already an issue opened for the test being flaky: #1309)

@briandorsey briandorsey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@lahuang4 lahuang4 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@mukund-ananthu
Copy link
Contributor

@parthea The Owlbot PostProcessor seems to be stuck indefinitely despite multiple force-runs. Could you PTAL / is this a known issue. cc: @lahuang4

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2025
@mukund-ananthu mukund-ananthu merged commit cb760a7 into googleapis:main Jan 31, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants