Skip to content

docs: update all public documents to use auto-generated admin clients.#1109

Merged
rahul2393 merged 6 commits intomainfrom
admin_sample_swap
Mar 4, 2024
Merged

docs: update all public documents to use auto-generated admin clients.#1109
rahul2393 merged 6 commits intomainfrom
admin_sample_swap

Conversation

@rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Feb 29, 2024 •
edited
Loading

  • Moved existing samples to - samples/samples/archived . The archived samples will be referenced from release notes, public docs, etc. so that older users can navigate to the older docs.
  • Moved new samples to - samples/samples (on merging the PR, this will ensure public documentation is updated since the name, file-path of sample is now same as what our documents reference).

@rahul2393 rahul2393 requested review from a team as code owners February 29, 2024 04:50
@rahul2393 rahul2393 requested a review from dandhlee February 29, 2024 04:50
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 29, 2024
@snippet-bot
Copy link

snippet-bot bot commented Feb 29, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 46 region tags.
You are about to delete 43 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 29, 2024
@rahul2393 rahul2393 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 29, 2024
@rahul2393 rahul2393 requested review from arpan14 and harshachinta and removed request for dandhlee February 29, 2024 05:16
@rahul2393 rahul2393 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 4, 2024
@rahul2393 rahul2393 merged commit d683a14 into main Mar 4, 2024
@rahul2393 rahul2393 deleted the admin_sample_swap branch March 4, 2024 06:54
@release-please release-please bot mentioned this pull request Mar 4, 2024
Merged
@harshachinta
Copy link
Contributor

harshachinta commented Mar 4, 2024

@rahul2393
Quick check on Snippet bot comment.
image

There is a mismatch in region tags that got updated. I am not sure of the reason but can you check if any tags got missed to be updated or got deleted?

@rahul2393
Copy link
Contributor Author

rahul2393 commented Mar 4, 2024 •
edited
Loading

@harshachinta It was expected, 3 samples which got missed from earlier merge was incorporated with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshachinta harshachinta Awaiting requested review from harshachinta

1 more reviewer

@arpan14 arpan14 arpan14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahul2393 @harshachinta @arpan14