-
Notifications
You must be signed in to change notification settings - Fork 167
Closed
Labels
api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Here is the method definition:
python-storage/google/cloud/storage/_helpers.py
Lines 311 to 318 in 792b21f
| def update( | |
| self, | |
| client=None, | |
| timeout=_DEFAULT_TIMEOUT, | |
| if_generation_match=None, | |
| if_generation_not_match=None, | |
| if_metageneration_match=None, | |
| if_metageneration_not_match=None, |
In the implementation if_generation_match and if_generation_not_match are missing.
python-storage/google/cloud/storage/_helpers.py
Lines 363 to 366 in 792b21f
| _add_generation_match_parameters( | |
| query_params, | |
| if_metageneration_match=if_metageneration_match, | |
| if_metageneration_not_match=if_metageneration_not_match, |
./cc @frankyn
Metadata
Metadata
Assignees
Labels
api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.