-
Notifications
You must be signed in to change notification settings - Fork 167
Closed
Labels
api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Parameter checksum exposed in upload_from_string method but didn't pass to the internal method upload_from_file
python-storage/google/cloud/storage/blob.py
Lines 2474 to 2486 in 9d5bb56
| def upload_from_string( | |
| self, | |
| data, | |
| content_type="text/plain", | |
| client=None, | |
| predefined_acl=None, | |
| if_generation_match=None, | |
| if_generation_not_match=None, | |
| if_metageneration_match=None, | |
| if_metageneration_not_match=None, | |
| timeout=_DEFAULT_TIMEOUT, | |
| checksum=None, | |
| ): |
python-storage/google/cloud/storage/blob.py
Lines 2567 to 2577 in 9d5bb56
| self.upload_from_file( | |
| file_obj=string_buffer, | |
| size=len(data), | |
| content_type=content_type, | |
| client=client, | |
| predefined_acl=predefined_acl, | |
| if_generation_match=if_generation_match, | |
| if_generation_not_match=if_generation_not_match, | |
| if_metageneration_match=if_metageneration_match, | |
| if_metageneration_not_match=if_metageneration_not_match, | |
| timeout=timeout, |
Metadata
Metadata
Assignees
Labels
api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.