You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the training data contains NaNs, Prophet's preprocess method panics:
panicked at /augurs/crates/augurs-prophet/src/prophet/prep.rs:318:40:
index out of bounds: the len is 297 but the index is 297
This is because we filter ds and y to remove NaNs, but don't adjust n accordingly (or any of the other seasonality/regressor fields, while we're at it).
We should move this filtering into a TrainingData::filter_nans() method. Ideally it would even consume self and return a new TrainingData, which would mean we could avoid having a mutable binding to data in preprocess and be sure we're not inadvertently mutating it anywhere else.
The text was updated successfully, but these errors were encountered:
When the training data contains NaNs, Prophet's preprocess method panics:
This is because we filter
ds
andy
to remove NaNs, but don't adjustn
accordingly (or any of the other seasonality/regressor fields, while we're at it).We should move this filtering into a
TrainingData::filter_nans()
method. Ideally it would even consumeself
and return a newTrainingData
, which would mean we could avoid having a mutable binding todata
inpreprocess
and be sure we're not inadvertently mutating it anywhere else.The text was updated successfully, but these errors were encountered: