Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default runner image to grafana/k6:latest #452

Open
yorugac opened this issue Aug 22, 2024 · 0 comments
Open

Change the default runner image to grafana/k6:latest #452

yorugac opened this issue Aug 22, 2024 · 0 comments
Labels
breaking change Breaking change can impact some existing workflows. enhancement New feature or request evaluation needed

Comments

@yorugac
Copy link
Collaborator

yorugac commented Aug 22, 2024

Feature Description

k6-operator currently uses a public image hosted at our ghcr as a default image for runners.
This image is built from the Dockerfile on each release of k6-operator. Under the hood, runner image is the grafana/k6:latest with the wrapper that makes it usable in Envoy setup by default.

This approach has a drawback: default version of k6 used by k6-operator depends on the time of release:
https://github.com/grafana/k6-operator/blob/main/docs/versioning.md
Worse, for k6-operator to use the latest version of k6 by default (i.e. without utilizing .spec.runner.image in TestRun), the operator must be released after corresponding k6 release.

Suggested Solution (optional)

We can switch to use grafana/k6:latest image as the default in the k6-operator. The latest k6 historically points only to the latest release and can be considered stable. This way, k6-operator will always use the latest stable version of k6 by default, with all features included.

However, this will break current default compatibility with Istio: users who rely on it will have to start passing custom runner images in TestRun spec.

If we go this route, there will also be a related question of whether we should continue to build and host runner images. We can continue to build them as now, on k6-operator release, assuming Istio users will use them in .spec.runner.image of TestRun.

Community feedback will be appreciated!

Already existing or connected issues / PRs (optional)

Related question recently came up:

@yorugac yorugac added enhancement New feature or request evaluation needed breaking change Breaking change can impact some existing workflows. labels Aug 22, 2024
@yorugac yorugac changed the title Change the default runner image Change the default runner image to grafana/k6:latest Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change can impact some existing workflows. enhancement New feature or request evaluation needed
Projects
None yet
Development

No branches or pull requests

1 participant