Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cleanup post option to all #454

Open
yorugac opened this issue Aug 23, 2024 · 0 comments
Open

Rename cleanup post option to all #454

yorugac opened this issue Aug 23, 2024 · 0 comments
Labels
breaking change Breaking change can impact some existing workflows. enhancement New feature or request UX

Comments

@yorugac
Copy link
Collaborator

yorugac commented Aug 23, 2024

Feature Description

Currently .spec.cleanup in TestRun supports only one option, "post". When set, it results in k6-operator cleaning up the CR and all its resources after the test run finishes. In #275, a request for at least one more option was made. It makes senses to rename "post" to "all" as it better reflects what is happening.

Suggested Solution (optional)

Such a rename would be a breaking change. We can support both "post" and "all" for some time, with deprecation warning for "post".

Already existing or connected issues / PRs (optional)

As an additional context. Initially, the choice of the word was made probably to mean that resources are cleaned up "post" (after) the test run. But it's hard to imagine that we will ever have the need in, for example, cleanup: "pre" -- before the test run. At the same time, we already have a request from #275 to limit the amount of test runs impacted instead.

@yorugac yorugac added enhancement New feature or request UX breaking change Breaking change can impact some existing workflows. labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change can impact some existing workflows. enhancement New feature or request UX
Projects
None yet
Development

No branches or pull requests

1 participant