Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The related methods of Inspector basically lack the transmission of ctx #872

Open
shuqingzai opened this issue Apr 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@shuqingzai
Copy link

Describe the bug

The Inspector method cannot pass ctx to control the execution of the broker. It should be allowed to enter the parameter ctx.

See: https://github.com/hibiken/asynq/blob/2b632b93d5d57a9302ad82a4b028830daa030c73/inspector.go

@shuqingzai shuqingzai added the bug Something isn't working label Apr 28, 2024
@cold-bin
Copy link

cold-bin commented May 4, 2024

I think asynq inspector don't need context in function. inspector is only called by asynqmon in order to inspect asynq now. why do you need ctx ?

@shuqingzai
Copy link
Author

I think asynq inspector don't need context in function. inspector is only called by asynqmon in order to inspect asynq now. why do you need ctx ?

@cold-bin

  1. This is a public API. It is not only used in asynqmon. You can use it anytime and anywhere.
  2. Add ctx for request timeout control, opentelemetry tracing and other functions have been expanded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants