You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the messages refactor some errors, mostly deserialization ones, were set as String in places like FromStr or TryFrom implementations.
It would be idiomatic to create dedicated types for them along with a crate wide error type. An example of a place that could use a dedicated error type would be the TryFrom<MessageType<'a>> for CredentialPreviewMsgType.
Steps:
- [ ] Move MsgTypeError to the msg_types module.
- [ ] Create crate wide error type.
- [ ] Create dedicated error types instead of String errors.
The text was updated successfully, but these errors were encountered:
As part of the
messages
refactor some errors, mostly deserialization ones, were set asString
in places likeFromStr
orTryFrom
implementations.It would be idiomatic to create dedicated types for them along with a crate wide error type. An example of a place that could use a dedicated error type would be the
TryFrom<MessageType<'a>> for CredentialPreviewMsgType
.Steps:
- [ ] Move
MsgTypeError
to themsg_types
module.- [ ] Create crate wide error type.
- [ ] Create dedicated error types instead of
String
errors.The text was updated successfully, but these errors were encountered: