Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated errors instead of Strings in messages crate #819

Open
bobozaur opened this issue May 2, 2023 · 1 comment
Open

Dedicated errors instead of Strings in messages crate #819

bobozaur opened this issue May 2, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@bobozaur
Copy link
Contributor

bobozaur commented May 2, 2023

As part of the messages refactor some errors, mostly deserialization ones, were set as String in places like FromStr or TryFrom implementations.

It would be idiomatic to create dedicated types for them along with a crate wide error type. An example of a place that could use a dedicated error type would be the TryFrom<MessageType<'a>> for CredentialPreviewMsgType.

Steps:
- [ ] Move MsgTypeError to the msg_types module.
- [ ] Create crate wide error type.
- [ ] Create dedicated error types instead of String errors.

@bobozaur bobozaur added the good first issue Good for newcomers label May 2, 2023
@SumantxD
Copy link

SumantxD commented May 7, 2023

@bobozaur I would like to work on this issue, could you assign it to me plz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants