-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credential and Presentation attributes mime-type adjustments #820
Labels
good first issue
Good for newcomers
Comments
@bobozaur I would like to work on this issue could you assign it to me plz. |
@bobozaur can you help me locate Attribute struct inside the file structure, i'am struggling to find it |
@SumantxD My bad, the struct rename was already done but I was looking at an older branch when drafting this issue. I updated the issue description to match the main branch. |
SumantxD
added a commit
to SumantxD/aries-vcx
that referenced
this issue
May 7, 2023
SumantxD
added a commit
to SumantxD/aries-vcx
that referenced
this issue
May 7, 2023
Signed-off-by: SumantxD <[email protected]>
SumantxD
added a commit
to SumantxD/aries-vcx
that referenced
this issue
May 9, 2023
Signed-off-by: SumantxD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The attributes (
CredentialAttr
andPresentationAttr
) could benefit from handling thevalue
andmime-type
pair in a different manner. Right now both fields are deserialized and handling would have to be done based on whether aMimeType
is present or not.A better idea would be to use an
AttrValue
#[serde(flatten)]
enum with two variants:Plain { value: String }
Encoded { value: String, mime_type: MaybeKnown<MimeType> }
Note the
MaybeKnown
enum use, which would also be a beneficial addition in case we get a mime_type we don't recognize.Having the attribute value deserialized this way would make handling it easier since we can match and deduce that:
Plain
, it's just a string,Encoded
, it's a base64 encoded string that then has to be processed according to theMimeType
.Steps:
- [ ] Wrap
MimeType
inMaybeKnown
- [ ] Create and use the
AttrValue
enum in both attribute types.The text was updated successfully, but these errors were encountered: