Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor messages crate tests #866

Closed
wants to merge 1 commit into from
Closed

Refactor messages crate tests #866

wants to merge 1 commit into from

Conversation

tech-bash
Copy link
Contributor

fix: #822

Just want to know that the direction in which I'm going is upright! For using the Static JSON in message crate tests

Refactor messages crate
bc4ed1d 
Signed-off-by: Bhavy Airi <[email protected]>
@tech-bash tech-bash force-pushed the refactor/messageTests branch from 43690a8 to bc4ed1d Compare June 1, 2023 13:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #866 (43690a8) into main (1222ef7) will decrease coverage by 3.79%.
The diff coverage is n/a.

❗ Current head 43690a8 differs from pull request most recent head bc4ed1d. Consider uploading reports for the commit bc4ed1d to get more accurate results

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   48.96%   45.17%   -3.79%     
==========================================
  Files         429      429              
  Lines       34225    34225              
  Branches     7594     7594              
==========================================
- Hits        16759    15462    -1297     
- Misses      12208    13838    +1630     
+ Partials     5258     4925     -333
Flag Coverage Δ
unittests-aries-vcx 45.16% <ø> (-3.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fields/protocols/cred_issuance/issue_credential.rs 52.94% <ø> (ø)
...fields/protocols/cred_issuance/offer_credential.rs 50.00% <ø> (ø)
...elds/protocols/cred_issuance/propose_credential.rs 46.15% <ø> (ø)
...elds/protocols/cred_issuance/request_credential.rs 54.54% <ø> (ø)

... and 57 files with indirect coverage changes

@Patrik-Stas
Copy link
Contributor

closing per inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use static JSON in messages crate tests
3 participants
@tech-bash @codecov-commenter @Patrik-Stas