Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified DIDs #881

Open
mirgee opened this issue Jun 13, 2023 · 3 comments
Open

Use qualified DIDs #881

mirgee opened this issue Jun 13, 2023 · 3 comments

Comments

@mirgee
Copy link
Contributor

mirgee commented Jun 13, 2023

Currently, we are generating and storing method-less, unqualified DIDs both when creating a pairwise peer DID and an issuer DID, and then passing the values around as strings. This may be fine for now, as did:sov is the only method supported by aries-vcx, but as we are already planning to introduce support for did:indy and more, we should start qualifying DIDs to avoid ambiguity in the future. We should use mutually convertible types for qualified and unqualified DIDs (as perhaps we can still use unqualified DIDs in places and situations where the method can be inferred, like when dealing with a specific ledger transactions).

A simple-minded experiment conducted to see the downstream consequences of the switch done by simply passing a method value instead of None to create_and_store_my_did shows that this will lead to different ledger primitive (credential definition, schema, revocation registry definition) IDs, regardless of whether generated by libvdrtools or credex - both use slightly different logic when dealing with qualified DIDs.

This will also require creating a migration tool for wallets of clients who have been using the current version of aries-vcx for some time and need to continue using their connections, issuer DIDs and ledger primitives.

@swcurran
Copy link
Member

We’re working on this in ACA-Py as well. Are you familiar with the discussions in the Aries community on dealing with the two types of unqualified DIDs we have — those on an Indy ledger (converted to did:sov for now), and Peer DIDs. For the Peer DIDs, we’re currently planning on migrating them to did:peer:2 and did:peer:3.

Happy to discuss further and to make sure there is alignment across Aries in this conversion.

@mirgee
Copy link
Contributor Author

mirgee commented Jun 13, 2023

I was not aware of related discussions, thanks for pointing them out, @swcurran ! I found (and will keep tracking) this and this issue. Any other conversations we should be plugged into?

@swcurran
Copy link
Member

The one other to mention is trying to come up with a mobile wallet-friendly, scalable mediator. We’re going to be talking about that at the next weekly Aries WG meeting — next Wednesday at 7:00 Pacific / 16:00 Central Europe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants