Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefly crashes when the configured connector is not available on start up but not when running #1277

Open
Chengxuan opened this issue Apr 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Chengxuan
Copy link
Contributor

There are two aspects of this:

  1. we should have consistent behaviour between start-up time and running time. And preferably, firefly shouldn't crash due to one dependency throwing an error as other things could be in a usable state
  2. better error surfacing for the errors
@Chengxuan Chengxuan added the bug Something isn't working label Apr 17, 2023
@hyperledger hyperledger deleted a comment from hosie Apr 18, 2023
@nguyer
Copy link
Contributor

nguyer commented Apr 18, 2023

Firefly crashes when the configured connector is not available on start up but not when running

This is true, and is working as designed. Now, we may want to change that design. The intention was that if FireFly wasn't configured correctly it would not start, forcing someone to intervene and reconfigure it correctly. As opposed to, if it was configured correctly and had been running for some time, but the connector suddenly became unavailable, it should not crash, but simply wait until it comes back. On startup, there is no way to know the difference between an improper config, or a connector that just isn't there temporarily, so we've taken the "fail fast" approach for now.

@Chengxuan
Copy link
Contributor Author

Chengxuan commented Apr 18, 2023

Thanks for providing the background. It does make sense for users to be aware of faulty configuration at an early stage so they can act on it.

I'm not sure whether multi-namespace support and dynamic configuration reload were factored in for this design. It feels the additions of those two critical features are worth us rethinking on that decision so that we have better isolations logic between namespaces (e.g. I don't have to fix all namespaces just to start Firefly UI to use the only one I care).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants