Get a misleading error message when uploading file to data endpoint without setting a file name

[lil131]

If uploading a file to the /namespaces/{ns}/data endpoint, and the file name is "" or not set, the request will fail with a misleading error message:

{
"error": "FF10218: Error reading multi-part form input: EOF"
}

[lil131]

firefly/internal/apiserver/server.go

Lines 130 to 152 in e9b7b74

	for {
	part, err := mpr.NextPart()
	if err != nil {
	return nil, i18n.WrapError(ctx, err, i18n.MsgMultiPartFormReadError)
	}
	if part.FileName() == "" {
	value, _ := ioutil.ReadAll(part)
	formParams[part.FormName()] = string(value)
	} else {
	l.Debugf("Processing multi-part upload. Field='%s' Filename='%s'", part.FormName(), part.FileName())
	mp := &fftypes.Multipart{
	Data: part,
	Filename: part.FileName(),
	Mimetype: part.Header.Get("Content-Disposition"),
	}
	return &multipartState{
	mpr: mpr,
	formParams: formParams,
	part: mp,
	close: func() { _ = part.Close() },
	}, nil
	}
	}

[AryanSharma9917]

Heyy @lil131 , @awrichar , can I work on this issue?

[AryanSharma9917]

Here's what I can perform

func uploadHandler(w http.ResponseWriter, r *http.Request) {

// Check if the file name is empty or not set
file, header, err := r.FormFile("file")
if err != nil {

	http.Error(w, err.Error(), http.StatusInternalServerError)
	return
}
defer file.Close()
if header.Filename == "" {
	http.Error(w, "Error: File name is empty or not set", http.StatusBadRequest)
	return
}

fmt.Fprintf(w, "File uploaded successfully!")

}