Skip to content

Use RFC-compliant RPKI-ROV procedure #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
job wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use RFC-compliant RPKI-ROV procedure #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/api/v4/router/as112/bird2/neighbors.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ function fn_import ( int remote_as ) -> bool
<?php if( $t->router->rpki ): ?>

# RPKI check - deny invalids
if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_INVALID ) then {
print "Ignore RPKI invalid ", net, " for ASN ", bgp_path.last_nonaggregated;
if ( roa_check( t_roa ) = ROA_INVALID ) then {
print "Ignore RPKI invalid ", net, " for ASN ", bgp_path.last;
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions resources/views/api/v4/router/collector/bird2-2025/neighbors.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ function f_import_as<?= $int['autsys'] ?>() -> bool
<?php if( $t->router->rpki && config( 'ixp.rpki.rtr1.host' ) ): ?>

# RPKI check
if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_INVALID ) then {
if ( roa_check( t_roa ) = ROA_INVALID ) then {
bgp_large_community.add( IXP_LC_FILTERED_RPKI_INVALID );
} else if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_VALID ) then {
} else if ( roa_check( t_roa ) = ROA_VALID ) then {
bgp_large_community.add( IXP_LC_INFO_RPKI_VALID );
} else {
# RPKI unknown, keep checking and mark as unknown for info
Expand Down
4 changes: 2 additions & 2 deletions resources/views/api/v4/router/collector/bird2/neighbors.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ function f_import_as<?= $int['autsys'] ?>()
<?php if( $t->router->rpki && config( 'ixp.rpki.rtr1.host' ) ): ?>

# RPKI check
if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_INVALID ) then {
if ( roa_check( t_roa ) = ROA_INVALID ) then {
bgp_large_community.add( IXP_LC_FILTERED_RPKI_INVALID );
} else if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_VALID ) then {
} else if ( roa_check( t_roa ) = ROA_VALID ) then {
bgp_large_community.add( IXP_LC_INFO_RPKI_VALID );
} else {
# RPKI unknown, keep checking and mark as unknown for info
Expand Down
4 changes: 2 additions & 2 deletions resources/views/api/v4/router/server/bird2-2025/rpki.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@
function filter_rpki() -> bool
{
# RPKI check
if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_INVALID ) then {
if ( roa_check( t_roa ) = ROA_INVALID ) then {
print "Tagging invalid ROA ", net, " for ASN ", bgp_path.last;
bgp_large_community.add( IXP_LC_FILTERED_RPKI_INVALID );
return true;
}

if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_VALID ) then {
if ( roa_check( t_roa ) = ROA_VALID ) then {
bgp_large_community.add( IXP_LC_INFO_RPKI_VALID );
return true;
}
Expand Down
4 changes: 2 additions & 2 deletions resources/views/api/v4/router/server/bird2/rpki.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@
function filter_rpki()
{
# RPKI check
if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_INVALID ) then {
if ( roa_check( t_roa ) = ROA_INVALID ) then {
print "Tagging invalid ROA ", net, " for ASN ", bgp_path.last;
bgp_large_community.add( IXP_LC_FILTERED_RPKI_INVALID );
return true;
}

if( roa_check( t_roa, net, bgp_path.last_nonaggregated ) = ROA_VALID ) then {
if ( roa_check( t_roa ) = ROA_VALID ) then {
bgp_large_community.add( IXP_LC_INFO_RPKI_VALID );
return true;
}
Expand Down