chore: adjust libflux workspace to be idiomatic #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252c269 to
b20bbba
Compare
adrian-thurston
approved these changes
Nov 24, 2020
_Obligatory: apologies for using the term "idiomatic" here; I couldn't find a better word._ When working with a rust workspace, it is usually in the context of multiple connected crates. Our use of multiple crates is needed and makes sense. However, the crates aren't laid out the way a normal crate would be laid out, and the `src` in the workspace is usually not there. This patch simplifies the rust workspace layout, removes some overrides in various `Cargo.toml` files, and fixes the build accordingly. Fixes influxdata#2342
b20bbba to
9208613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obligatory: apologies for using the term "idiomatic" here; I couldn't
find a better word.
When working with a rust workspace, it is usually in the context of
multiple connected crates. Our use of multiple crates is needed and
makes sense. However, the crates aren't laid out the way a normal crate
would be laid out, and the
srcin the workspace is usually not there.This patch simplifies the rust workspace layout, removes some overrides
in various
Cargo.tomlfiles, and fixes the build accordingly.Fixes #2342