Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): implement lastSuccess in the tasks package #3180

Merged
merged 1 commit into from
Sep 8, 2020
Merged

feat(stdlib): implement lastSuccess in the tasks package #3180

merged 1 commit into from
Sep 8, 2020

Conversation

jsternberg
Copy link
Contributor

Fixes #3173.

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@jsternberg jsternberg force-pushed the feat/tasks-last-success branch from 43aa5cd to 51c9ac6 Compare September 8, 2020 15:53
@codecov-commenter
Copy link

Codecov Report

Merging #3180 into master will decrease coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
- Coverage   50.40%   50.40%   -0.01%     
==========================================
  Files         337      337              
  Lines       41237    41248      +11     
==========================================
+ Hits        20786    20791       +5     
- Misses      17989    17992       +3     
- Partials     2462     2465       +3
Impacted Files Coverage Δ
stdlib/influxdata/influxdb/tasks/flux_gen.go 100.00% <ø> (ø)
stdlib/influxdata/influxdb/tasks/tasks.go 61.90% <52.94%> (-19.92%) ⬇️
stdlib/test_packages.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdaccd9...51c9ac6. Read the comment docs.

@jsternberg jsternberg requested a review from rockstar September 8, 2020 16:10
@jsternberg jsternberg merged commit 003acd6 into master Sep 8, 2020
@jsternberg jsternberg deleted the feat/tasks-last-success branch September 8, 2020 16:38
jsternberg added a commit that referenced this pull request Sep 8, 2020
@jsternberg
feat(stdlib): implement lastSuccess in the tasks package (#3180)
c381098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockstar rockstar rockstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a way to access flux options from builtins
3 participants
@jsternberg @codecov-commenter @rockstar