Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rounding from metrics added to reports. #190

Closed
christophermadsen opened this issue Aug 31, 2022 · 0 comments
Closed

Remove rounding from metrics added to reports. #190

christophermadsen opened this issue Aug 31, 2022 · 0 comments

Comments

@christophermadsen
Copy link
Contributor

When reporting training and validation metrics, we round to 3 decimals, but this unnecessarily removes experiment granularity that some users might need.

probatus/probatus/feature_elimination/feature_elimination.py

Lines 573 to 582 in f409c8e

# Report results
self._report_current_results(
round_number=round_number,
current_features_set=current_features_set,
features_to_remove=features_to_remove,
train_metric_mean=np.round(np.mean(scores_train), 3),
train_metric_std=np.round(np.std(scores_train), 3),
val_metric_mean=np.round(np.mean(scores_val), 3),
val_metric_std=np.round(np.std(scores_val), 3),
)

I propose that we refrain from using any unnecessary rounding and remove it from the lines above.
This was referenced Aug 31, 2022
Merged
Closed
@daaf89 daaf89 mentioned this issue Mar 13, 2024
Merged
ReinierKoops pushed a commit that referenced this issue Mar 17, 2024
@daaf89
Remove rounding of metrics to improve granularity (#238)
bd83153 
Rounding reported metrics to 3 decimals unnecessarily removes
granularity that some users may need. It's better to remove this.

This is an update of the pull request proposed by @christophermadsen in
#190 and associated Pull Request, but it never made it onto main. I'm
hoping this can be included now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary rounding of metrics. christophermadsen/probatus
2 participants
@ReinierKoops @christophermadsen