Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for regressors next to classifiers #241

Closed
ReinierKoops opened this issue Mar 17, 2024 · 1 comment
Closed

Add explicit support for regressors next to classifiers #241

ReinierKoops opened this issue Mar 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ReinierKoops
Copy link

ReinierKoops commented Mar 17, 2024

Problem Description
Currently the focus of Probatus was (binary) Classifiers, however already (silently) there is support for regressors. The docstrings should reflect that as well as the example notebooks.

Desired Outcome
The notebooks and code reflect the reality and even perhaps expand on it functionality wise.

Solution Outline
First start with updating the code (naming of variables and docstring) then finish with the example notebooks. Lastly, update the readme of this repo and its description on github. Don't forget the description on Pypi.

@ReinierKoops
Copy link
Author

fixed in #248

ReinierKoops pushed a commit that referenced this issue Apr 11, 2024
…, removed unused code and updated notebooks to work (again). (#248)

This PR depends on the PR to be accepted:
#242

______

The PR fixes the following:

- Removed unused code and so partially fixed:
#245
- Updates all notebooks so they are all working:
#246
- Add explicit support for regressors and multiclass: :
#241 & :
#169
- Updated the yaml files for github actions. Now we have a weekly
cronjob (instead of daily) to test the notebooks.
- Enable tests which were previously failing or only enabled in certain
circumstances (much has changed the last 3 years with regards of
adoption of the Mac ARM architecture support)
- Removed most (if not all except one on purpose) of the copyright
notice in code.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant