bug: ionic should not re-focus an element when focus already moved on overlay dismiss by developer

[aeharding]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request

Allow developer to set custom focus during overlay dismissal.

Describe the Use Case

In the handler of an ion-action-sheet the developer may want to restore focus to a custom element, like a text box.

Describe Preferred Solution

Ionic overlay should detect whether focus has been set by developer, and not restore focus if that is so.

Describe Alternatives

None.

Reproduction

https://github.com/aeharding/test-focus

Additional Information

Not sure if this is considered a feature or a bug 😅

[liamdebeasi]

Thanks, I think this makes sense to have. However, you can provide a reproduction case so I can test your PR?

[aeharding]

No problem! https://github.com/aeharding/test-focus

[liamdebeasi]

Thanks! This request makes sense. Ionic tries to focus an element inside of the previous view. However, if focus is already in the previous view then we shouldn't attempt to move focus.