Skip to content

Conversation

@mapsandapps
Copy link
Contributor

Issue number: resolves Internal


What is the current behavior?

We are not ever explicitly setting aria-checked. For checked and unchecked states (i.e. true and false for aria-checked), we don't need to set aria-checked because an input with a type of 'checkbox' has built-in semantics making aria-checked redundant.

However, when the checkbox is in an indeterminate state, aria-checked should have a value of 'mixed'. We are not currently ever setting it to 'mixed'. See MDN for more details.

What is the new behavior?

  • The checkbox's aria-checked has a value of 'true' when it is checked
  • The checkbox's aria-checked has a value of 'false' when it is unchecked
  • The checkbox's aria-checked has a value of 'mixed' when it is indeterminate

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Mar 5, 2024
@mapsandapps mapsandapps marked this pull request as ready for review March 5, 2024 20:25
@mapsandapps mapsandapps added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit b2d636f Mar 6, 2024
@mapsandapps mapsandapps deleted the FW-6018 branch March 6, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants