Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dependencies into individual packages #530

Open
rajdip-b opened this issue Nov 11, 2024 · 10 comments
Open

Move the dependencies into individual packages #530

rajdip-b opened this issue Nov 11, 2024 · 10 comments
Labels
difficulty: 2 help wanted Extra attention is needed priority: low scope: general Anything related to this repository type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

Description

Turbo suggests that we should move all the package-specific dependencies into the individual package.json files even if these dependencies are shared. We would like to apply this to keyshade.

Solution

Copy the dependencies from root package.json and paste them into the packages that uses them.

@rajdip-b rajdip-b added help wanted Extra attention is needed type: chore Release drafter tag for tagging PRs related to making patches to general code scope: general Anything related to this repository priority: low difficulty: 2 labels Nov 11, 2024
@rovertrack
Copy link

/attempt

Copy link

Assigned the issue to @rovertrack!

@rajdip-b
Copy link
Member Author

@rovertrack any progress with this?

@rovertrack
Copy link

Nope unassign me.

@Souvik9205
Copy link
Contributor

/attempt

Copy link

Assigned the issue to @Souvik9205!

@Souvik9205 Souvik9205 removed their assignment Dec 25, 2024
@bansal-harsh-2504
Copy link
Contributor

/attempt

Copy link

github-actions bot commented Jan 6, 2025

Assigned the issue to @bansal-harsh-2504!

@bansal-harsh-2504
Copy link
Contributor

Hi there @rajdip-b ,

I wanted to discuss an approach I've been using for managing dependencies in our monorepo. Instead of manually checking every file for its dependencies, I've taken a more systematic approach:

Remove all dependencies from the root package.json
Run the project
Note the console errors
Add only the specific dependencies that are missing

but when I do pnpm i
then I got this

prepare$ husky
'husky' is not recognized as an internal or external command,
operable program or batch file.

Can you please guide me ?

@rajdip-b
Copy link
Member Author

Husky runs out hooks actually. I think it should be present in root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 help wanted Extra attention is needed priority: low scope: general Anything related to this repository type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
None yet
4 participants