Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The click area for PhET expirements is displaced #186

Closed
Jaifroid opened this issue Aug 31, 2021 · 3 comments · Fixed by #390
Closed

The click area for PhET expirements is displaced #186

Jaifroid opened this issue Aug 31, 2021 · 3 comments · Fixed by #390
Assignees
@Jaifroid
Labels
bug
Milestone
Release 2.5.0

Comments

@Jaifroid
Copy link
Member

PhET experiments run in KJSW in SW mode, but the click area is displaced by several pixels. This must be to do with the code for hiding and showing the toolbars, which has some kludges in it in an attempt to work around bootsrap issues. Since no user has complained, I assume very few users attempt to run PhET on the PWA version, but it should be fixed in a generic way.
@Jaifroid Jaifroid added the bug label Aug 31, 2021
@Jaifroid Jaifroid added this to the Release 1.8.0 milestone Aug 31, 2021
@Jaifroid Jaifroid self-assigned this Aug 31, 2021
@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 1, 2021

A workaround for now is to change the setting for "Hide toolbars" to "Never". Then the experiments are not displaced. This proves my hypothesis as to the cause above.

@Jaifroid Jaifroid mentioned this issue Sep 6, 2021
Open
@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 6, 2021

I've added instructions in About explaining the workaround.

@Jaifroid Jaifroid modified the milestones: Release 1.8.2, Release 2.0 Dec 4, 2021
@Jaifroid Jaifroid modified the milestones: Release 2.0.0, Release 2.1.0 May 30, 2022
@Jaifroid Jaifroid modified the milestones: Release 2.1.0, Release 2.2.0 Aug 30, 2022
@Jaifroid Jaifroid modified the milestones: Release 2.3.0, Release 2.4.0 Jan 5, 2023
@Jaifroid Jaifroid modified the milestones: Release 2.4.0, Release 2.5.0 Jan 20, 2023
@Jaifroid Jaifroid mentioned this issue Apr 21, 2023
Closed
Jaifroid added a commit that referenced this issue Apr 21, 2023
@Jaifroid
Fix UI issues with toolbars and downloads
4425e3f 
Fixes #186, #388, #389.
@Jaifroid Jaifroid mentioned this issue Apr 21, 2023
Merged
Jaifroid added a commit that referenced this issue Apr 23, 2023
@Jaifroid
Fix UI issues with toolbars and downloads (#390)
44c87a0 
Fixes #186, #388, #389.
@Jaifroid
Copy link
Member Author

Very pleased to have fixed this old bug!

Jaifroid added a commit that referenced this issue Apr 27, 2023
@Jaifroid
Fix UI issues with toolbars and downloads (#390)
2569814 
Fixes #186, #388, #389.
@Jaifroid Jaifroid modified the milestones: Release 2.6.0, Release 2.5.0 Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug
Projects
None yet
Milestone
Release 2.5.0
Development

Successfully merging a pull request may close this issue.

Fix UI issues with toolbars and downloads kiwix/kiwix-js-pwa
1 participant
@Jaifroid