Merge pull request kubernetes#5613 from hezhizhen/chore

Fix typo & replace deprecated functions & replace literals with constants

vertical-pod-autoscaler/MIGRATE.md

@@ -93,4 +93,4 @@ VPA objects that have been defined with `poc.autoscaling.k8s.io/v1alpha1`
 apiVersion. Then use `vpa-up.sh` to bring up the new version of VPA and create
 your VPA objects from the scratch, passing apiVersion
 `autoscaling.k8s.io/v1beta2` and switching from selector to targetRef, as
-described in the prevous section.
+described in the previous section.

vertical-pod-autoscaler/README.md

@@ -68,7 +68,7 @@ The current default version is Vertical Pod Autoscaler 0.13.0
 remove this API version. While for now you can continue to use `v1beta2` API we
 recommend using `autoscaling.k8s.io/v1` instead. `v1` and `v1beta2` APIs are
 almost identical (`v1` API has some fields which are not present in `v1beta2)
-so simply chaning which API version you're calling should be enough in almost
+so simply changing which API version you're calling should be enough in almost
 all cases.
 
 ### Notice on removal of v1beta1 version (>=0.5.0)

vertical-pod-autoscaler/enhancements/4902-delete-oom-pods/README.md

@@ -1,5 +1,5 @@
 **WARNING**
-:warning: We no longer intend to implemnt this KEP. Instead we recommend using
+:warning: We no longer intend to implement this KEP. Instead we recommend using
 [Unhealthy Pod Eviction Policy for PDBs](https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md).
 
 # KEP-4902: Delete OOM Pods
@@ -62,7 +62,7 @@ fit their needs.
 
 ## Design Details
 
-When the eviction fails the pod will not just get blindy deleted, but further
+When the eviction fails the pod will not just get blindly deleted, but further
 checks will occur. Which gives us the following checklist:
 - [ ] Was at least one container in the Pod terminated due to being OOM
       (`OOMKilled`)?

vertical-pod-autoscaler/pkg/admission-controller/README.md

@@ -2,7 +2,7 @@
 
 - [Intro](#intro)
 - [Running](#running)
-- [Implementation](#implmentation)
+- [Implementation](#implementation)
 
 ## Intro
 

vertical-pod-autoscaler/pkg/admission-controller/certs.go

@@ -17,7 +17,7 @@ limitations under the License.
 package main
 
 import (
-	"io/ioutil"
+	"os"
 
 	"k8s.io/klog/v2"
 )
@@ -31,7 +31,7 @@ type certsConfig struct {
 }
 
 func readFile(filePath string) []byte {
-	res, err := ioutil.ReadFile(filePath)
+	res, err := os.ReadFile(filePath)
 	if err != nil {
 		klog.Errorf("Error reading certificate file at %s: %v", filePath, err)
 		return nil

vertical-pod-autoscaler/pkg/admission-controller/gencerts.sh

@@ -48,7 +48,7 @@ if [[ $? -ne 0 ]]; then
 fi
 set -o errexit
 
-# Create a server certiticate
+# Create a server certificate
 openssl genrsa -out ${TMP_DIR}/serverKey.pem 2048
 # Note the CN is the DNS name of the service of the webhook.
 openssl req -new -key ${TMP_DIR}/serverKey.pem -out ${TMP_DIR}/server.csr -subj "/CN=vpa-webhook.kube-system.svc" -config ${TMP_DIR}/server.conf -addext "subjectAltName = DNS:vpa-webhook.kube-system.svc"

vertical-pod-autoscaler/pkg/admission-controller/logic/server.go

@@ -19,7 +19,7 @@ package logic
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"k8s.io/api/admission/v1"
@@ -133,7 +133,7 @@ func (s *AdmissionServer) Serve(w http.ResponseWriter, r *http.Request) {
 
 	var body []byte
 	if r.Body != nil {
-		if data, err := ioutil.ReadAll(r.Body); err == nil {
+		if data, err := io.ReadAll(r.Body); err == nil {
 			body = data
 		}
 	}

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

@@ -119,7 +119,7 @@ type PodUpdatePolicy struct {
 	MinReplicas *int32 `json:"minReplicas,omitempty" protobuf:"varint,2,opt,name=minReplicas"`
 }
 
-// UpdateMode controls when autoscaler applies changes to the pod resoures.
+// UpdateMode controls when autoscaler applies changes to the pod resources.
 // +kubebuilder:validation:Enum=Off;Initial;Recreate;Auto
 type UpdateMode string
 

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta1/types.go

@@ -84,7 +84,7 @@ type PodUpdatePolicy struct {
 	UpdateMode *UpdateMode `json:"updateMode,omitempty" protobuf:"bytes,1,opt,name=updateMode"`
 }
 
-// UpdateMode controls when autoscaler applies changes to the pod resoures.
+// UpdateMode controls when autoscaler applies changes to the pod resources.
 type UpdateMode string
 
 const (

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta2/types.go

@@ -99,7 +99,7 @@ type PodUpdatePolicy struct {
 	UpdateMode *UpdateMode `json:"updateMode,omitempty" protobuf:"bytes,1,opt,name=updateMode"`
 }
 
-// UpdateMode controls when autoscaler applies changes to the pod resoures.
+// UpdateMode controls when autoscaler applies changes to the pod resources.
 // +kubebuilder:validation:Enum=Off;Initial;Recreate;Auto
 type UpdateMode string
 

vertical-pod-autoscaler/pkg/apis/poc.autoscaling.k8s.io/v1alpha1/types.go

@@ -84,7 +84,7 @@ type PodUpdatePolicy struct {
 	UpdateMode *UpdateMode `json:"updateMode,omitempty" protobuf:"bytes,1,opt,name=updateMode"`
 }
 
-// UpdateMode controls when autoscaler applies changes to the pod resoures.
+// UpdateMode controls when autoscaler applies changes to the pod resources.
 type UpdateMode string
 
 const (

vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go

@@ -46,7 +46,7 @@ import (
 	v1lister "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/cache"
-	klog "k8s.io/klog/v2"
+	"k8s.io/klog/v2"
 	resourceclient "k8s.io/metrics/pkg/client/clientset/versioned/typed/metrics/v1beta1"
 )
 
@@ -310,13 +310,13 @@ func (feeder *clusterStateFeeder) GarbageCollectCheckpoints() {
 	klog.V(3).Info("Starting garbage collection of checkpoints")
 	feeder.LoadVPAs()
 
-	namspaceList, err := feeder.coreClient.Namespaces().List(context.TODO(), metav1.ListOptions{})
+	namespaceList, err := feeder.coreClient.Namespaces().List(context.TODO(), metav1.ListOptions{})
 	if err != nil {
 		klog.Errorf("Cannot list namespaces. Reason: %+v", err)
 		return
 	}
 
-	for _, namespaceItem := range namspaceList.Items {
+	for _, namespaceItem := range namespaceList.Items {
 		namespace := namespaceItem.Name
 		checkpointList, err := feeder.vpaCheckpointClient.VerticalPodAutoscalerCheckpoints(namespace).List(context.TODO(), metav1.ListOptions{})
 		if err != nil {
@@ -375,7 +375,7 @@ func filterVPAs(feeder *clusterStateFeeder, allVpaCRDs []*vpa_types.VerticalPodA
 	return vpaCRDs
 }
 
-// Fetch VPA objects and load them into the cluster state.
+// LoadVPAs fetches VPA objects and loads them into the cluster state.
 func (feeder *clusterStateFeeder) LoadVPAs() {
 	// List VPA API objects.
 	allVpaCRDs, err := feeder.vpaLister.List(labels.Everything())
@@ -424,7 +424,7 @@ func (feeder *clusterStateFeeder) LoadVPAs() {
 	feeder.clusterState.ObservedVpas = vpaCRDs
 }
 
-// Load pod into the cluster state.
+// LoadPods loads pod into the cluster state.
 func (feeder *clusterStateFeeder) LoadPods() {
 	podSpecs, err := feeder.specClient.GetPodSpecs()
 	if err != nil {