Remove INLINEs from GBinary/GSum methods #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These interact very badly with GHC 7.9.x's simplifier See also - https://ghc.haskell.org/trac/ghc/ticket/9630 and - https://ghc.haskell.org/trac/ghc/ticket/9583
hvr
added a commit
to ghc/packages-binary
that referenced
this pull request
Sep 25, 2014
These interact very badly with GHC 7.9.x's simplifier See also - https://ghc.haskell.org/trac/ghc/ticket/9630 and - https://ghc.haskell.org/trac/ghc/ticket/9583 Submitted upstream as haskell/binary#62
hvr
added a commit
to ghc/ghc
that referenced
this pull request
Sep 25, 2014
This removes a couple of `INLINE` pragmas from the generics helper classes. With this change the compile times and memory usage should go back to the previous GHC 7.8.3 situation. This has been submitted upstream as haskell/binary#62
Member
Author
|
bump |
Member
|
Thanks for the reminder. |
Member
Author
|
@kolmodin oh an btw, please try to get a release-candidate of |
kolmodin
added a commit
that referenced
this pull request
Dec 13, 2014
Remove INLINEs from GBinary/GSum methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These interact very badly with GHC 7.9.x's simplifier
See also