[Feature request] Add namespace and `svc` suffix for host configmap

[shaowei-su]

In the v2 implementation, headless worker service is referenced by jobname-worker-0.jobname-worker (https://github.com/alculquicondor/mpi-operator/blob/master/v2/pkg/controller/mpi_job_controller.go#L1110) which requires the pod /etc/resolv.conf config having namespace.svc.cluster.local presented.

The tf-operator on the other side composes TFCONFIG with both namespace and svc suffix: https://github.com/kubeflow/training-operator/blob/master/pkg/controller.v1/tensorflow/tensorflow.go#L159

Is it possible to consolidate the logic so that the same cluster DNS settings work for both operators?

[alculquicondor]

Isn't namespace.svc.cluster.local already added by kubelet?

In any case, I think it should all continue to work seamlessly if we add namespace.svc

[shaowei-su]

Not always the case depends on network level configs set up. I validated that adding namespace.svc works well like you mentioned.

[alculquicondor]

Feel free to send a PR

[shaowei-su]

PTAL #454

[alculquicondor]

Fixed in #454
/close

[google-oss-prow]

@alculquicondor: Closing this issue.

Details

In response to this:

Fixed in #454
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.