Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default behavior to no providers instead of all-providers #158

Closed
LiorLieberman opened this issue May 18, 2024 · 3 comments · Fixed by #159
Closed

Changing default behavior to no providers instead of all-providers #158

LiorLieberman opened this issue May 18, 2024 · 3 comments · Fixed by #159
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@LiorLieberman
Copy link
Member

What would you like to be added:
Default behavior needs to change to not include any provider by default

Why this is needed:
Including all provider by default causes us many problems. Two example are #127 and #138.

Also, most people would only have have one provider, and in case of more providers installed, they can run the tool multiple times.

/help
/triage accepted

@LiorLieberman LiorLieberman added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2024
@k8s-ci-robot
Copy link
Contributor

@LiorLieberman:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:
Default behavior needs to change to not include any provider by default

Why this is needed:
Including all provider by default causes us many problems. Two example are #127 and #138.

Also, most people would only have have one provider, and in case of more providers installed, they can run the tool multiple times.

/help
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 18, 2024
@LiorLieberman
Copy link
Member Author

cc: @levikobi @mlavacca

@mlavacca
Copy link
Member

mlavacca commented Jun 5, 2024

An additional problem of running all providers by default is that with the addition of the openapi provider, now if no provider is passed as argument, the tool tries to use all the regular providers plus openapi, which does not really make much sense. I think we should set the providers flag to be mandatory instead of defaulting to all providers.

@LiorLieberman LiorLieberman self-assigned this Jun 5, 2024
keithmattix added a commit to keithmattix/ingress2gateway that referenced this issue Nov 9, 2024
`providers` were marked required in kubernetes-sigs#158, but docs still show it as optional
k8s-ci-robot pushed a commit that referenced this issue Nov 14, 2024
`providers` were marked required in #158, but docs still show it as optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants