Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default no providers, mark providers required #159

Merged
merged 3 commits into from
Jun 13, 2024
Merged

default no providers, mark providers required #159

merged 3 commits into from
Jun 13, 2024

Conversation

LiorLieberman
Copy link
Member

What type of PR is this?

What this PR does / why we need it:
/kind feature

Which issue(s) this PR fixes:

Fixes #158

Does this PR introduce a user-facing change?:

providers flag is now required

/cc @mlavacca

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2024
LiorLieberman
LiorLieberman commented Jun 5, 2024
View reviewed changes
cmd/print.go Outdated Show resolved Hide resolved
mlavacca
mlavacca reviewed Jun 6, 2024
View reviewed changes
cmd/print.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
mlavacca
mlavacca reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a minor nit, lgtm

cmd/print.go Outdated Show resolved Hide resolved
@LiorLieberman
Copy link
Member Author

mind leaving lgtm?

@mlavacca
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LiorLieberman,mlavacca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d67e59 into kubernetes-sigs:main Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca left review comments

@guicassolato guicassolato guicassolato left review comments

Assignees

@mlavacca mlavacca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing default behavior to no providers instead of all-providers
4 participants
@LiorLieberman @mlavacca @k8s-ci-robot @guicassolato