Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Manage a specified portion of resources #1209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Sep 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #1122

Special notes for your reviewer:

Compatibility with existing flags and configurations

This allows you to specify resources to manage, not just nodes.

Use --manage Node:metadata.name=<nodename> instead of --manage-single-node <nodename>.
Use --manage Node instead of --manage-all-nodes.
Use --manage Node:metadata.annotations.<key>=<value> instead of --manage-nodes-with-annotation-selector <key>=<value>.
Use --manage Node:metadata.labels.<key>=<value> instead of --manage-nodes-with-label-selector <key>=<value>.
and have the same configuration change

[BROKEN] Use --manage will no longer manage all resources with Stages by default; it will only manage specified resources.

Examples

Use --manage VirtualMachineInstance.kubevirt.io/v1 to specified https://github.com/kubevirt/kubevirtci/blob/4cc10185aca83b7d884183ecf6ff7dfc040f23fc/cluster-provision/k8s/1.31/manifests/kwok/kubevirt/stage/vmi-ready.yaml

Does this PR introduce a user-facing change?

Add --manage to specify which resources to manage instead of --manage-* 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 8c9bd26
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66de9489700512000803aaef

@wzshiming wzshiming force-pushed the feat/flag-manage branch 8 times, most recently from bf7e65d to 4726c33 Compare September 3, 2024 07:17
@wzshiming wzshiming changed the title [WIP] Use manage to specify resources Manage a specified portion of resources Sep 4, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
@wzshiming wzshiming changed the title Manage a specified portion of resources [WIP] Manage a specified portion of resources Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@wzshiming wzshiming force-pushed the feat/flag-manage branch 3 times, most recently from 7027e3b to 5ba035d Compare September 9, 2024 06:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants