Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypicking tracker issue for v1.9 #626

Closed
3 tasks done
luxas opened this issue Dec 26, 2017 · 5 comments
Closed
3 tasks done

Cherrypicking tracker issue for v1.9 #626

luxas opened this issue Dec 26, 2017 · 5 comments
Assignees
Labels
area/releasing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@luxas
Copy link
Member

luxas commented Dec 26, 2017

This issue serves as an umbrella to track the kubeadm-related PRs we cherrypick into the v1.9 branch.

I've been a cherrypick lead for the kubeadm releases so far, but didn't come up with the idea to track things in a centralized manner like this before ¯_(ツ)_/¯

I propose that @timothysc function as the cherrypick lead on the kubeadm side for v1.9

I've identified a list of PRs to be cherrypicked:

Individual cherrypick PRs should be created as documented here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md

TL;DR; download https://github.com/github/hub, make sure git remote -v looks something like this and execute:

$ git remote -v
origin	[email protected]:luxas/kubernetes.git (fetch)
origin	[email protected]:luxas/kubernetes.git (push)
upstream	https://github.com/kubernetes/kubernetes (fetch)
upstream	DISABLE (push)

# Example command
GITHUB_USER=luxas hack/cherry_pick_pull.sh upstream/release-1.9 57296

The script will do everything for you, including creating the PR. You only need to get approval from @timothysc / me as kubeadm approvers and @mbohlool that is the v1.9 patch manager and then the cherrypick can be merged!

@luxas luxas added this to the v1.9 milestone Dec 26, 2017
@luxas luxas added area/releasing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 26, 2017
@xiangpengzhao
Copy link

Oh! I was thinking of cherry-picking kubernetes/kubernetes#57296 when it was lgtm'd but I forgot it after it got merged. 😅

cherry-pick PRs sent:
kubernetes/kubernetes#57632
kubernetes/kubernetes#57633

@mattkelly
Copy link

Here you go: kubernetes/kubernetes#57635. Just let me know if I need to fix anything up!

@timothysc
Copy link
Member

From what I can tell all the above PR's have been cherry-picked.

@xiangpengzhao
Copy link

kubernetes/kubernetes#57811 (Update etcd version to 3.1.11 for release 1.9) instead of kubernetes/kubernetes#57633

@timothysc
Copy link
Member

I'm going to close out this issue now, as it's past it's lifetime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/releasing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants