Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Discovery for Events and Listeners Causes Duplicate Listener Entries and Conflicts with Manual Registration #53533

Open
votkapower opened this issue Nov 15, 2024 · 2 comments

Comments

@votkapower
Copy link

Laravel Version

11.31

PHP Version

8.2

Database Driver & Version

Mysql

Description

Problem Description

Laravel's auto-discovery for events and listeners, along with its automatic linking, is a fantastic feature. However, there is no way to disable this functionality.

When you manually specify listeners for each event in the AppServiceProvider and then run php artisan event:list, the listeners are listed twice—once from auto-discovery and once from manual registration.

This creates a conflict, especially when you want to control the order of execution. Currently:

  • The execution order of listeners is unclear.
  • There is no documented way to define or enforce the order of execution.

Suggested Improvement

Laravel should provide a method to disable the auto-linking of events and listeners. This would allow developers to manually specify listeners and their order, ensuring a predictable and controlled execution flow.

Related Issues I found reporting similar concerns, such as this one: #52714

Steps To Reproduce

Follow steps into this issue: #52714

@votkapower
Copy link
Author

tried:

  • php artisan cache:clear
  • composer dump autoload
  • tried creating new EventServiceProvider with the old $listens prop

Still for my custom evets I see double the listenrs once ending with "@handle" and once without. Is there any solution to remove the duplicates and configure the order of execution?

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants