Repository navigation
feat: alias command to invite members - #84
Merged
k3llymariee merged 8 commits intoMar 28, 2024
Merged
Conversation
|
This pull request has been linked to Shortcut Story #235705: create alias command to invite members. |
k3llymariee
commented
Mar 27, 2024
| "ldcli/internal/members" | ||
| ) | ||
|
|
||
| const defaultRole = "reader" |
Contributor
Author
There was a problem hiding this comment.
we can also pass in an option --role flag to override this if we want?
Contributor
There was a problem hiding this comment.
That makes sense. It could be --role/-r.
Contributor
Author
There was a problem hiding this comment.
| return nil, errors.NewAPIError(err) | ||
| } | ||
| memberJson, err := json.Marshal(members.Items[0]) | ||
| memberJson, err := json.Marshal(members.Items) |
Contributor
Author
There was a problem hiding this comment.
is it weird to return an array of members for the create command? if so I can add additional logic here
Contributor
There was a problem hiding this comment.
A little, yeah, but it's weird from our API, not here.
k3llymariee
marked this pull request as ready for review
March 27, 2024 22:55
dbolson
approved these changes
Mar 28, 2024
| return nil, errors.NewAPIError(err) | ||
| } | ||
| memberJson, err := json.Marshal(members.Items[0]) | ||
| memberJson, err := json.Marshal(members.Items) |
Contributor
There was a problem hiding this comment.
A little, yeah, but it's weird from our API, not here.
| "ldcli/internal/members" | ||
| ) | ||
|
|
||
| const defaultRole = "reader" |
Contributor
There was a problem hiding this comment.
That makes sense. It could be --role/-r.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new command to invite members using a list of emails passed in as a flag. Under the hood, this uses the same
Createmethod that themembers createcommand uses, which was refactored to take in a list of emails.OR