Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report used JDK version #1076

Open
ennru opened this issue Aug 25, 2022 · 3 comments
Open

Report used JDK version #1076

ennru opened this issue Aug 25, 2022 · 3 comments
Labels
kalix-runtime Runtime and SDKs sub-team

Comments

@ennru
Copy link
Member

ennru commented Aug 25, 2022

Most users will just keep the JDK version we provide in samples.
Over time this might change and we should keep track of used JDKs and their versions.

Refs https://github.com/lightbend/kalix/issues/4722, #1045

@ennru ennru added the kalix-runtime Runtime and SDKs sub-team label Aug 25, 2022
@patriknw
Copy link
Contributor

I think we already populate that in the serviceRuntime, which is sent to the proxy in the discovery call.

serviceRuntime = sys.props.getOrElse("java.runtime.name", "")
+ " " + sys.props.getOrElse("java.runtime.version", ""),

@beritou
Copy link
Contributor

beritou commented Aug 25, 2022

I think we already populate that in the serviceRuntime, which is sent to the proxy in the discovery call.

This is correct. This information is currently already being logged. Here's an example:

Received Spec from user function: service name: [], service version: [], service runtime: [OpenJDK Runtime Environment 11.0.11+9], protocol version: [1.0], sdk: [kalix-java-sdk-1.0.2], proxy version [1.0.12], project [007ef2b5-d428-4700-a598-33e02b600421], service [realtimetransitdemo], service-uid [dc1fb64e-c2d5-4566-ad87-5e6d0ae38187], env [prod], region [us-east1],

@ennru
Copy link
Member Author

ennru commented Aug 30, 2022

Ok, that's great. We "just" need to make Grafana parse it and report it -- and show it in our Kalix Metrics dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kalix-runtime Runtime and SDKs sub-team
Projects
None yet
Development

No branches or pull requests

3 participants