Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Timing Attacks section with a definition, use cryptography as an example #44

Open
sam-ellis opened this issue Oct 11, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@sam-ellis
Copy link
Collaborator

The Timing Attacks section launches straight in with cryptography as a place where timing attacks are used, possibly leading to the conclusion that cryptography is the only place where timing attacks occur. I would recommend to re-write the first paragraph to define Timing Attacks abstractly first, then use cryptography as an example of where this can occur.

@kbeyls
Copy link
Member

kbeyls commented Oct 11, 2021

Thank you, I think this is a very good suggestion!

@kbeyls kbeyls added the good first issue Good for newcomers label Oct 11, 2021
@kbeyls
Copy link
Member

kbeyls commented Oct 11, 2021

@allcontributors please add @sam-ellis for bug, ideas, review

@allcontributors
Copy link
Contributor

@kbeyls

I've put up a pull request to add @sam-ellis! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants