Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a github action to check that the font cachebuster was updated #20991

Closed
bx80 opened this issue Jul 10, 2023 · 0 comments · Fixed by #20973
Closed

Add a github action to check that the font cachebuster was updated #20991

bx80 opened this issue Jul 10, 2023 · 0 comments · Fixed by #20973
Assignees
@bx80
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
5.0.0

Comments

@bx80
Copy link
Contributor

bx80 commented Jul 10, 2023

Context

When the Matomo font is changed by developer the cachebuster URL parameter in the icons stylesheet should also be updated to ensure that any browser cache of the old font is invalidated, however this step is often overlooked.

Expected Behavior

There should be a github action which will check if the font was updated, if so then the stylesheet font loading line should be checked against the base branch and the check should fail if it has not be updated.

Current Behavior

There is no check, so it's up to the developer to remember to do this manually.
@bx80 bx80 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jul 10, 2023
@bx80 bx80 self-assigned this Jul 10, 2023
@bx80 bx80 mentioned this issue Jul 10, 2023
Merged
11 tasks
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 28, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bx80 bx80

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Github action to check that the font cachebuster was updated matomo-org/matomo
2 participants
@sgiehl @bx80