-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect URL parameter in update notification #21447
Conversation
Should we perhaps wrap https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/Morpheus/javascripts/piwikHelper.js#L36-L58 in |
I think that would be a better outcome than a hard fail, it's possible that future usage of the external link methods, either in core or plugins, could result in invalid URLs causing a similar crash, so minimizing the potential impact makes sense 👍 |
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <[email protected]> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <[email protected]> Co-authored-by: michalkleiner <[email protected]> Co-authored-by: bx80 <[email protected]>
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <[email protected]> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <[email protected]> Co-authored-by: michalkleiner <[email protected]> Co-authored-by: bx80 <[email protected]>
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <[email protected]> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <[email protected]> Co-authored-by: michalkleiner <[email protected]> Co-authored-by: bx80 <[email protected]>
Description:
Fixes #21446
Corrects an invalid URL causing a JS crash when an update is detected.
Review