[Bug] Tracking Code requires Overlay plugin to be enabled

[mikkeschiren]

What happened?

With Overlay plugin deactivated, and you go to

Measureables -> Tracking Code

You get a warning:

The plugin Overlay is not enabled. You can activate the plugin on Settings > Plugins page in Matomo.

It also makes the area to get the Tracking Code for JavaScript non working (empty).

What should happen?

You should get the Tracking Code, and no warning.

How can this be reproduced?

Deactivate Overlay plugin if it is enabled.

Then you go to:
Measureables -> Tracking Code

You get the warning and nothing for the Tracking Code.

Matomo version

5.0.2

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

Uncaught exception in API: /var/www/html/core/Plugin/Manager.php(303): The plugin Overlay is not enabled. You can activate the plugin on Settings > Plugins page in Matomo. [Query: ?date=yesterday&module=API&format=json&method=Overlay.getExcludedQueryParameters&idSite=1&filter_limit=-1&segment=&period=day, CLI mode: 0]

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[mikkeschiren]

Suggested solution would be to add public function getExcludedQueryParameters($idSite) to CoreAdminCore, that would cause code duplication, but it also makes core functionality work without the need of a none required plugin, and will not break anything. I can create a pull request for this.

[sgiehl]

Thanks for the report. This indeed shouldn't be that case. I'll prepare a fix for that.