Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Plugin Management might offer updating a plugin even if plugins admin is disabled in config #22539

Closed
4 tasks done
sgiehl opened this issue Aug 28, 2024 · 0 comments · Fixed by #22538
Closed
4 tasks done
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Aug 28, 2024

What happened?

When setting enable_plugins_admin = 0 in config, Matomo should not allow updating or installing any plugins through the UI.
Instead the plugin management currently shows available updates and even sometimes gives the option to check and update them. Clicking the update button then results in an error.

plugin_admin.mp4

What should happen?

Matomo should not show the possibility to update any plugins in that case.

How can this be reproduced?

  • Set enable_plugins_admin = 0 in config
  • Ensure plugin updates are available, e.g. by checking out an older version of a submodule
  • Check plugin management page

Matomo version

5

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Aug 28, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Aug 28, 2024
@sgiehl sgiehl self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant