Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets are stored in iCloud Keychain #326

Closed
jeroenleenarts opened this issue Oct 5, 2019 · 3 comments
Closed

Secrets are stored in iCloud Keychain #326

jeroenleenarts opened this issue Oct 5, 2019 · 3 comments

Comments

@jeroenleenarts
Copy link

I think the secrets are stored on iCloud. But that the secrets are just not visible on other devices due to the identifier list stored on user defaults.

I might be wrong. But worth checking out since you clearly indicate not storing stuff outside of the app. I base this on not seeing a “this device” only flag in this repo or the otp component one.

@jeroenleenarts
Copy link
Author

Double checked. Not seeing any option being passed with the keychain attribute dict like ‘ kSecAttrAccessibleWhenUnlockedThisDeviceOnly’

@jeroenleenarts
Copy link
Author

I read up a bit on Cloud KeyChain
kSecAttrSynchronizable is not used, so items are not sync-able.

@beaucollins
Copy link
Collaborator

#6 #309 are related

Also worth noting iCloud has restored my tokens ever since having two-factor and iCloud keychain

#330 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants