Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refine] Client - configuration #72

Open
mdabrowski1990 opened this issue Sep 7, 2021 · 0 comments
Open

[refine] Client - configuration #72

mdabrowski1990 opened this issue Sep 7, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation implementation Changes to code

Comments

@mdabrowski1990
Copy link
Owner

mdabrowski1990 commented Sep 7, 2021

Requires

#78
#5
#96

Description

As a user, I would like to set all communication parameters on client side, so I can reuse them during communication instead of providing them over and over again.

Client configuration includes:

  • DeltaP2request, DeltaP2response, DeltaP6request, DeltaP6response,
    • min value = 0
    • actual value - set by user
  • DeltaP2
    • actual value = DeltaP2request + DeltaP2response
  • DeltaP6
    • actual value = DeltaP6request + DeltaP6response
  • P2server
    • max value = 50ms by default, but can be changed by the user
  • P2client
    • min value = P2server_max + DeltaP2
    • actual value - set by user
  • P6client
    • min value = P2server_max + DeltaP6
    • actual value - set by user
  • P2*client
    • min value = P2*server_max + DeltaP2response
    • actual value - set by user
  • P6*client
    • min value = P2*server_max + DeltaP6response
    • actual value - set by user
  • P3Client_phys, P3Client_func
    • min value = P2server_max + DeltaP2
    • actual value - set by user

User is unable to set invalid values, e.g.:

  • User cannot set any value below 0.
  • User cannot set any actual value below min or above max.
  • User is warned and actual value is adjusted if user just influenced min/max value and actual value is no longer in range.

Test Strategy

Unit Tests:

  • 100% decisions coverage for implemented code

Acceptance Criteria

  • It is possible to adjust all Client's parameters that are not constant values, even after the object is created.
  • All Client's communication parameters are described in knowledge base.
  • User documentation is updated with client configuration examples and explanation.
@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Sep 7, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Client - request sending [refine] Client - lonely request transmission Sep 7, 2021
@mdabrowski1990 mdabrowski1990 added the documentation Improvements or additions to documentation label Sep 7, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Client - lonely request transmission [refine] Client - configuration Sep 7, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Client - configuration Client - configuration Sep 7, 2021
@mdabrowski1990 mdabrowski1990 changed the title Client - configuration [refine] Client - configuration Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation implementation Changes to code
Projects
None yet
Development

No branches or pull requests

1 participant