Draft of text data record #303
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
===========================================
- Coverage 100.00% 98.70% -1.30%
===========================================
Files 49 50 +1
Lines 2890 2928 +38
Branches 356 360 +4
===========================================
Hits 2890 2890
- Misses 0 38 +38
|
| from .raw_data_record import RawDataRecord | ||
|
|
||
|
|
||
| class TextDataRecord(RawDataRecord, AbstractDataRecord): |
There was a problem hiding this comment.
please, call it TextTableDataRecord (cause we are going to have one more text data record)
| if isinstance(physical_value, int): | ||
| return physical_value | ||
| if isinstance(physical_value, str): | ||
| if physical_value in self.__reversed_mapping: |
There was a problem hiding this comment.
use self.reversed_mapping instead of self.__reversed_mapping
| return physical_value | ||
| if isinstance(physical_value, str): | ||
| if physical_value in self.__reversed_mapping: | ||
| return self.__reversed_mapping[physical_value] |
mdabrowski1990
requested changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft implementation of TextDataRecord class which will translate provided data into human readable text.
How Has This Been Tested?
Unit tests will be available soon.
Process
I know the process and did my best to follow it