Instrument Apache CXF's JAX-RS implementation

[punitsi]

Metrics http_server_requests_seconds_count in Spring Boot application with version 2.0.8.Release exposed using spring actuator contains uri as "UNKNOWN". Spring Boot application is using cxf-spring-boot-starter-jaxrs for exposing rest endpoints.
I have added micrometer-registry-prometheus dependency in my project.

http_server_requests_seconds_count{exception="None",method="POST",status="200",uri="UNKNOWN",} 2.0

Actual

http_server_requests_seconds_count{exception="None",method="POST",status="200",uri="UNKNOWN",} 2.0

Expected:

http_server_requests_seconds_count{exception="None",method="GET",status="200",uri="/sayHello",} 2.0

micrometer-cxf implementation i believe similiar to micrometer-jersey2 should resolve the issue.

[shakuzen]

I don't have any CXF experience, but I would first advise trying with the latest versions, as something may have been fixed. If it is not fixed in the latest versions, please provide a sample application where we can reproduce the problem to better understand what is missing.

[mweirauch]

As already stated here, Apache CXF is an alternative JAX-RS implementation, which differs from the Jersey JAX-RS implementation which we covered with micrometer-jersey2.

So I think one would need a Apache CXF specific implementation to produce HTTP request metrics like we do for Jersey2. (The implementation then should produce the same style of metrics like WebMVC, WebFlux and Jersey2 to keep these in line.)

[marcingrzejszczak]

Isn't this fixed via apache/cxf#1346 ?

[github-actions]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[catia-talend]

Hello @marcingrzejszczak .

This issue still occurs when using CXF 4.x (combined with Spring Boot 3.x). URI tag is always UNKNOWN for http_server_requests. cxf_server_requests are working fine, but not http_server_requests.

I have attached a pet project to reproduce the issue. This example project is based on https://github.com/apache/cxf/tree/main/distribution/src/main/release/samples/jax_rs/spring_boot .
In this project, we're using CXF 4.0.3 and Spring Boot 3.1.1 .

Simply run:

curl -s http://127.0.0.1:8080/services/sayHello/world
Hello world, Welcome to CXF RS Spring Boot World!!!

curl -s http://127.0.0.1:8080/services/notFound


curl -s http://127.0.0.1:8080/actuator/prometheus | grep requests_seconds_count
http_server_requests_seconds_count{error="none",exception="none",method="GET",outcome="CLIENT_ERROR",status="404",uri="NOT_FOUND",} 1.0
http_server_requests_seconds_count{error="none",exception="none",method="GET",outcome="SUCCESS",status="200",uri="UNKNOWN",} 1.0
cxf_server_requests_seconds_count{exception="None",method="GET",operation="sayHello",outcome="SUCCESS",status="200",uri="/services/sayHello/{a}",} 1.0

Thank you and kind regards.

[github-actions]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.