Skip to content

Commit 873a827

Browse files
amkhalaf-githubcompulimcorinagum
authored
Fix aria-pressed for AC submit buttons (#3744)
* fix aria-pressed * Update __tests__/adaptiveCards.js Co-authored-by: William Wong <[email protected]> * Update packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js Co-authored-by: William Wong <[email protected]> * update CHANGELOG.md * missing brackets * update test snapshot * update snapshot * update test snapshot * add test timeout to wait for click post scroll action * Revert broken card PNG Co-authored-by: William Wong <[email protected]> Co-authored-by: Corina <[email protected]> Co-authored-by: William Wong <[email protected]>
1 parent ead34d4 commit 873a827

File tree

23 files changed

+42
-122
lines changed

23 files changed

+42
-122
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
6363
- Fixes [#3718](https://github.com/microsoft/BotFramework-WebChat/issues/3718). Fixed `webpack.config.js` to use default settings of `['browser', 'module', 'main']` and resolved issues with `uuid` package in IE11, by [@compulim](https://github.com/compulim) in PR [#3726](https://github.com/microsoft/BotFramework-WebChat/pull/3726)
6464
- Fixes [#3622](https://github.com/microsoft/BotFramework-WebChat/issues/3622). Apply pushed button style options and `aria-pressed` on Adaptive Cards selected buttons, by [@amal-khalaf](https://github.com/amal-khalaf) in PR [#3710](https://github.com/microsoft/BotFramework-WebChat/pull/3710)
6565
- Fixes [#3618](https://github.com/microsoft/BotFramework-WebChat/issues/3618). Fix Adaptive Cards anchors being disabled when Adaptive Cards is obsolete, by [@corinagum](https://github.com/corinagum) in PR [#3687](https://github.com/microsoft/BotFramework-WebChat/pull/3687)
66+
- Fixes [#3747](https://github.com/microsoft/BotFramework-WebChat/issues/3747). `aria-pressed` and `aria-role` is not properly set on Adaptive Cards submit buttons, by [@amal-khalaf](https://github.com/amal-khalaf) in PR [#3744](https://github.com/microsoft/BotFramework-WebChat/pull/3744)
6667
- Fixes [#3750](https://github.com/microsoft/BotFramework-WebChat/issues/3750). Debump Node.js engines requirements for some packages to `12.0.0`, by [@compulim](https://github.com/compulim) in PR [#3753](https://github.com/microsoft/BotFramework-WebChat/pull/3753)
6768

6869
### Changed
-3 Bytes
Loading
0 Bytes
Loading
32.7 KB
Loading
-13 Bytes
Loading
Loading
Loading
-5 Bytes
Loading
-14 Bytes
Loading
17 Bytes
Loading

0 commit comments

Comments
 (0)