New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early exit in HTTP Parser if content-length exceeds max_body_size #6701

Open

achamayou opened this issue Dec 11, 2024 · 0 comments

Member

achamayou commented Dec 11, 2024

See microsoft/scitt-ccf-ledger#247

We would need to add a check in

CCF/src/http/http_parser.h

Line 196 in 93f3ae4

headers.emplace(partial_parsed_header);

for content-length, and terminate early there. At the moment, this is checked later on, while the body is appended to:

CCF/src/http/http_parser.h

Line 249 in 93f3ae4

auto const& max_body_size = configuration.max_body_size.value_or(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment