Save & restore the state of [Net.ServicePointManager]::SecurityProtocol (#240)

giuseppecampanelli · web-flow · commit 618398eedd45 · 2020-06-18T12:44:16.000-07:00
[Net.ServicePointManager]::SecurityProtocol is a global configuration that was being modified during the execution of `Invoke-GHRestMethod`. With this change, the global state will be cached before the change and restored immediately afterwards. Fixes #230
diff --git a/GitHubCore.ps1 b/GitHubCore.ps1
@@ -201,6 +201,7 @@ function Invoke-GHRestMethod
     }
 
     $NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus
+    $originalSecurityProtocol = [Net.ServicePointManager]::SecurityProtocol
 
     try
     {
@@ -560,6 +561,10 @@ function Invoke-GHRestMethod
         Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus
         throw $newLineOutput
     }
+    finally
+    {
+        [Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol
+    }
 }
 
 function Invoke-GHRestMethodMultipleResult

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ function Invoke-GHRestMethod`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`$NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus`
	`204`	`+ $originalSecurityProtocol = [Net.ServicePointManager]::SecurityProtocol`
`204`	`205`
`205`	`206`	`try`
`206`	`207`	`{`
`@@ -560,6 +561,10 @@ function Invoke-GHRestMethod`
`560`	`561`	`Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus`
`561`	`562`	`throw $newLineOutput`
`562`	`563`	`}`
	`564`	`+ finally`
	`565`	`+ {`
	`566`	`+ [Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol`
	`567`	`+ }`
`563`	`568`	`}`
`564`	`569`
`565`	`570`	`function Invoke-GHRestMethodMultipleResult`