Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

port: ResumeDialog is not called after resumption with adaptivedialog (#5426) #1131

Closed
#1140
Closed
port: ResumeDialog is not called after resumption with adaptivedialog (#5426)#1131
#1140
Labels
ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.
Milestone
R13
@github-actions

Description

@github-actions
github-actions
bot
opened on Apr 6, 2021

The changes in ResumeDialog is not called after resumption with adaptivedialog (#5426) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5401

Description

  • Updated AdaptiveDialog to store the interruption status in TurnPath.Interrupted so other dialogs can check it and decide if they need to reprompt or continue.
  • Updated InputDialog and SkillDialog to check on interruption status to decide if it is going to reprompt or continue.
  • Update SkillConversationFactory to always return a unique (and different) ID every time CreateSkillConversationIdAsync (this should also address Conversation flow breaks when using more than 1 skill in a dialog botframework-sdk#6248

Please review and, if necessary, port the changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions