Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

SDK sets default locale for JVM #1466

@gombosg

Description

@gombosg

Version

What package version of the SDK are you using.
4.14.2

Describe the bug

Very strange localization issues appeared in our production application, like formatting dates in Chinese, Portuguese etc. Incidentally, soon after rolling out our Teams app which is part of our backend monolith. Turns out the SDK sets the default locale since #1074 with Locale.setDefault() which is JVM global.

To Reproduce

Steps to reproduce the behavior:

  1. Send a message to a bot with locale other than en_US
  2. Default locale changes, verify with Locale.getDefault()

Expected behavior

Locale.setDefault() is not run by the SDK as it's JVM-wide.

Screenshots

If applicable, add screenshots to help explain your problem
image
.

Additional context

Add any other context about the problem here.
Happens in BotAdapter.java here.

Metadata

Metadata

Assignees

Labels

Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.customer-reportedIssue is created by anyone that is not a collaborator in the repository.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions