This repository was archived by the owner on Dec 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
SDK sets default locale for JVM #1466
Copy link
Copy link
Closed as not planned
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.
Description
Version
What package version of the SDK are you using.
4.14.2
Describe the bug
Very strange localization issues appeared in our production application, like formatting dates in Chinese, Portuguese etc. Incidentally, soon after rolling out our Teams app which is part of our backend monolith. Turns out the SDK sets the default locale since #1074 with Locale.setDefault() which is JVM global.
To Reproduce
Steps to reproduce the behavior:
- Send a message to a bot with locale other than
en_US - Default locale changes, verify with
Locale.getDefault()
Expected behavior
Locale.setDefault() is not run by the SDK as it's JVM-wide.
Screenshots
If applicable, add screenshots to help explain your problem

.
Additional context
Add any other context about the problem here.
Happens in BotAdapter.java here.
g-piffa
Metadata
Metadata
Assignees
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.