Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some OD tests execute only on GPU but should also execute on CPU #416

Open
PatrickBue opened this issue Nov 8, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@PatrickBue
Copy link
Contributor

Description

Some of the object detection tests have the gpu marker and hence only get tested on GPU machines, even though these tests could also run on CPU. See an example below. The reason is the dependency on od_detection_learner which internally runs 1 training epoch and as part of that runs coco evaluation which has the dependency on GPU. In theory this (and other) tests should also run on un-trained models.

@pytest.mark.gpu
@pytest.fixture(scope="session")
def saved_model(od_detection_learner, tiny_od_data_path) -> Union[str, Path]:
""" A saved model so that loading functions can reuse. """
model_name = "test_fixture_model"
od_detection_learner.save(model_name)
assert (Path(tiny_od_data_path) / "models" / model_name).exists()
return model_name, Path(tiny_od_data_path) / "models"

In which platform does it happen?

Only non-gpu tests are affected.

Expected behavior (i.e. solution)

More tests get executed on CPU-only machines

@PatrickBue PatrickBue added the bug Something isn't working label Nov 8, 2019
@PatrickBue PatrickBue changed the title [BUG] [BUG] Some OD tests execute only on GPU but should also execute on CPU Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant